fix: process each entity only once and in topological order#1662
Merged
triceo merged 2 commits intoJun 27, 2025
Merged
Conversation
Previously, the code relied on eventually consistency to avoid collections (that is, sometimes suppliers will be called with stale data, but will always eventually be called with correct data). Now, an initial sort is done to ensure no data is stale, and a map and comparator are utilized to prevent unnecessary computations.
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
approved these changes
Jun 27, 2025
triceo
force-pushed
the
fix/sort-changed-before-processing
branch
from
93e3fbb to
5c48308
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the code relied on eventually consistency to avoid collections (that is, sometimes suppliers will be called with stale data, but will always eventually be called with correct data).
Now, an initial sort is done to ensure no data is stale, and a map and comparator are utilized to prevent unnecessary computations.